Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

omnitrace-sample #169

Merged
merged 15 commits into from
Sep 30, 2022
Merged

omnitrace-sample #169

merged 15 commits into from
Sep 30, 2022

Conversation

jrmadsen
Copy link
Collaborator

@jrmadsen jrmadsen commented Sep 27, 2022 •
edited
Loading

  • omnitrace-sample executable which executes sampling (no instrumentation)
  • fixes bug with OMPT ignoring value of OMNITRACE_USE_OMPT
  • fixes some issues with sampling duration
  • new OMNITRACE_SAMPLING_INCLUDE_INLINES configuration variable
  • restricts process-sampling to 100 interrupts/sec when inheriting value from OMNITRACE_SAMPLING_FREQ
    • OMNITRACE_PROCESS_SAMPLING_FREQ still supports up to 1000 interrupts/sec
  • fixes bug with colorized log not truly being disabled in all instances
  • adds tests for omnitrace-sample
  • adds tests for sampling duration
  • settings ROCP_TOOL_LIB to libomnitrace-dl throws error
    • rocprofiler does not configure correctly when this is done
  • Quiet numa_gotcha warnings
  • Fixed some shadowed variables

@jrmadsen jrmadsen force-pushed the omnitrace-run branch 5 times, most recently from da4638f to 7b9c913 Compare September 28, 2022 14:39
@jrmadsen jrmadsen changed the title omnitrace-run omnitrace-sample Sep 28, 2022
@jrmadsen
omnitrace-run executable
d15b2bf
@jrmadsen
Fix thread_info::is_valid_time when threads do not terminate
8b2b650 
- was discarding samples
- timemory fixes for BFD support
@jrmadsen
fork fixes + sampling updates
51eef5a 
- more options for omnitrace-run
- OMNITRACE_SAMPLING_INCLUDE_INLINES
- fixed OMPT not being disabled
- fixed sampling duration
- fixed LD_PRELOAD when forked
@jrmadsen
Fix mpi-flat tests
84957d5
@jrmadsen
Fix segfault from OMPT after finalization
9bc2159
@jrmadsen jrmadsen force-pushed the omnitrace-run branch 3 times, most recently from 06f3b74 to 6680e07 Compare September 28, 2022 20:53
@jrmadsen jrmadsen added documentation Improvements or additions to documentation bug fix Fixes a bug timemory Issue affects/involves timemory features/capabilities libomnitrace Involves omnitrace library libomnitrace-dl Involves omnitrace-dl library labels Sep 30, 2022
@jrmadsen jrmadsen added sampling Statistical sampling via interrupts OMPT OpenMP tools testing Extends/improves/modifies testing cmake Modifies the CMake build system cpack Modifies the CPack packaging system submodule Updates a git submodule configuration Changes/involves configuration options rocprofiler GPU kernel HW counters omnitrace-sample Involves the omnitrace-sample executable labels Sep 30, 2022
@jrmadsen
Copy link
Collaborator Author

Merging into main despite not passing testing (yet) in order to make these updates available for NERSC dry-run. Will fix any failures (which would be unexpected) by EOD.

@jrmadsen jrmadsen merged commit 79a8f16 into ROCm:main Sep 30, 2022
@jrmadsen jrmadsen deleted the omnitrace-run branch September 30, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug fix Fixes a bug cmake Modifies the CMake build system configuration Changes/involves configuration options cpack Modifies the CPack packaging system documentation Improvements or additions to documentation libomnitrace Involves omnitrace library libomnitrace-dl Involves omnitrace-dl library omnitrace-sample Involves the omnitrace-sample executable OMPT OpenMP tools rocprofiler GPU kernel HW counters sampling Statistical sampling via interrupts submodule Updates a git submodule testing Extends/improves/modifies testing timemory Issue affects/involves timemory features/capabilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jrmadsen